[PATCH] Update LLVM 3.7 for DataLayout changes

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 09:27:00 PDT 2015


I've committed this to the branch in r245948.

Thanks,
Hans

On Mon, Aug 24, 2015 at 9:30 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
> Yes, I don’t make any assumption on the result of the current discussion with the community on this aspect, and by default I take care not to remove *anything* in the meantime :)
>
> Thanks,
>
> Mehdi
>
>
>> On Aug 24, 2015, at 9:29 PM, Chris Lattner <clattner at apple.com> wrote:
>>
>> The patch as it stands looks fine to me.
>>
>> However, the follow-on question of whether it makes sense to remove/change C APIs is something the broader community should decide on going forward.
>>
>> -Chris
>>
>>> On Aug 24, 2015, at 9:22 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>>>
>>> Hi Chris,
>>>
>>> Here is the patch.
>>>
>>>
>>> <Deprecate-the-DataLayout-on-the-TargetMachine-and-ba.patch>
>>>
>>> Purpose is:
>>>
>>> - Provide more information in the Release Notes about what changed with the DataLayout. This should help out-of-tree users to upgrade.
>>> - Deprecate LLVMGetTargetMachineData in the C API and provide hints where to look for a replacement.
>>> - Deprecate TargetMachine::getDataLayout(), and backport the replacement from trunk (TargetMachine::createDataLayout()), so that users don’t have to wait 3.8 to move away of a deprecated API.
>>>
>>> Except the back-ported entry point on the TargetMachine, this is NFC.
>>>>>> Mehdi
>>>
>>>
>>>
>>>> On Aug 24, 2015, at 8:59 PM, Chris Lattner <clattner at apple.com> wrote:
>>>>
>>>> Can I get a link to the patch?
>>>>
>>>> -Chris
>>>>
>>>>> On Aug 24, 2015, at 5:38 PM, Hans Wennborg <hans at chromium.org> wrote:
>>>>>
>>>>> We will need an RC4 before the final release, and this seems important
>>>>> enough that it could go in, but I would like to get approval from the
>>>>> code owner before merging.
>>>>>
>>>>> On Fri, Aug 21, 2015 at 2:17 PM, Hans Wennborg <hans at chromium.org> wrote:
>>>>>> +Chris for ownership
>>>>>>
>>>>>> On Thu, Aug 20, 2015 at 7:05 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>>>>>>> Here is a patch that I’d like to get in 3.7. It:
>>>>>>
>>>>>> Oh, why do these things always come up last-minute before the release?
>>>>>> Thanks for paying attention to 3.7, though :-)
>>>>>>
>>>>>>> - provides more information in the Release notes about what changes with the DataLayout. This should help out-of-tree users.
>>>>>>
>>>>>> Nice, thanks.
>>>>>>
>>>>>>> - Deprecate LLVMGetTargetMachineData in the C API
>>>>>>> - Deprecate TargetMachine::getDataLayout(), and backports the replacement from trunk (TargetMachine::createDataLayout())
>>>>>>
>>>>>> We've just tagged 3.7.0-rc3, and I was hoping that would become the
>>>>>> final release. But I can see that getting this in would be good, and
>>>>>> it also seems like a pretty safe change, so maybe we can squeeze it
>>>>>> in.
>>>>>>
>>>>>> There's no explicit code owner for this, which means Chris owns it.
>>>>>> Does the patch itself look OK for you?
>>>>>>
>>>>>> Thanks,
>>>>>> Hans
>>>>
>>>
>>
>


More information about the llvm-commits mailing list