[PATCH] D9444: Use ISL to Determine Loop Trip Count

[Johannes Doerfert via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, if it passes LNT (and maybe even your internal test). I will work on the domain modeling again soon but this is a really good starting point.


================
Comment at: lib/Analysis/ScopDetection.cpp:784
@@ +783,3 @@
+        (isa<SCEVAddRecExpr>(RHS) && !isInvariant(*Op0, CurRegion)))
+      return false;
+  }
----------------
For now we can be restrictive but could you explain to me why do we need this part? I want to refactor the Domain creation soon and any information you have would be usefull.


http://reviews.llvm.org/D9444