[PATCH] D12292: [CMake] merge add_compiler_rt_runtime and add_compiler_rt_darwin_runtime into a single function

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: lib/profile/CMakeLists.txt:21
@@ -21,7 +20,3 @@
 else()
-  foreach(arch ${PROFILE_SUPPORTED_ARCH})
-    add_compiler_rt_runtime(clang_rt.profile-${arch} ${arch} STATIC
-      CFLAGS -fPIC
-      SOURCES ${PROFILE_SOURCES})
-    add_dependencies(profile clang_rt.profile-${arch})
-  endforeach()
+  add_compiler_rt_runtime(clang_rt.profile
+    STATIC
----------------
beanz wrote:
> samsonov wrote:
> > Please leave the loop over PROFILE_SUPPORTED_ARCH here for this change, and let's collapse it here (and in similar places, like lsan) in subsequent changes.
> Please make up your mind over whether or not you want me to adapt the CMakeLists.txt files in this patch. In your comments here you have both asked me to make more changes to the CMakeLists files, and to make less changes.
Sorry if I wasn't clear enough. I suggest to leave
  foreach(arch ${XXX_SUPPORTED_ARCH})
in every `lib/xxx/CMakeLists.txt` as is: that is, pass a single arch to `add_compiler_rt_runtime` on non-Apple platforms for now.


http://reviews.llvm.org/D12292