[PATCH] D12266: Assume intrinsic handling in globalopt

Nick Lewycky via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 17:10:18 PDT 2015


nlewycky accepted this revision.
nlewycky added a comment.
This revision is now accepted and ready to land.

This looks correct, but probably not enough.

The point of assumes is that you need them because you're assuming something you don't know, and which globalopt probably also doesn't know. For instance, that a load from an external is equal to some particular value. Globalopt will stop processing when it sees that load, and never get to the assume.


================
Comment at: test/Transforms/GlobalOpt/assume.ll:12
@@ +11,3 @@
+
+define void @_GLOBAL__I_a() personality i8* undef {
+enter:
----------------
What's up with the personality? Is this needed for the testcase?


http://reviews.llvm.org/D12266





More information about the llvm-commits mailing list