[PATCH] D11981: [asan] On OS X, log reports to syslog and os_trace

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 13:09:05 PDT 2015


kcc added a comment.

In http://reviews.llvm.org/D11981#226987, @filcab wrote:

> I was looking at this and… Shouldn't something like this be in sanitizer_common, and then all the sanitizers could use it?
>  It seems to me that our method of reporting errors is different from sanitizer to sanitizer, and changes like this would need to be done again for other sanitizers, which doesn't seem very nice.


Yes, as I've also mentioned above we should move most of this Mac-specific code to sanitizer_mac.cc (which is in sanitizer_common).


http://reviews.llvm.org/D11981





More information about the llvm-commits mailing list