[PATCH] D1622: Make variable argument intrinsics behave correctly in a Win64 CC function.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 11:49:10 PDT 2015


rnk added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:15112-15114
@@ +15111,5 @@
+  MachineFunction &MF = DAG.getMachineFunction();
+  if ((Subtarget->isTargetWin64() &&
+       MF.getFunction()->getCallingConv() != CallingConv::X86_64_SysV) ||
+      Subtarget->isCallingConvWin64(MF.getFunction()->getCallingConv()))
+    // The Win64 ABI uses char* instead of a structure.
----------------
I'm assuming this extra condition was needed for some test case? Should we change isCallingConvWin64 instead maybe?


http://reviews.llvm.org/D1622





More information about the llvm-commits mailing list