[PATCH] D12277: [X86] Add intrinsic support for clac, stac, lgdt and sgdt

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 08:58:11 PDT 2015


rnk added inline comments.

================
Comment at: lib/Target/X86/X86InstrSystem.td:394
@@ -393,3 +393,3 @@
 let SchedRW = [WriteSystem] in {
-def SGDT16m : I<0x01, MRM0m, (outs opaque48mem:$dst), (ins),
+def SGDT16m : I<0x01, MRM0m, (outs), (ins opaque48mem:$dst),
               "sgdt{w}\t$dst", [], IIC_SGDT>, TB, OpSize16, Requires<[Not64BitMode]>;
----------------
Why should these change to ins? lgdt goes from memory into the chip and sgdt goes from the chip out to memory, right?


http://reviews.llvm.org/D12277





More information about the llvm-commits mailing list