[PATCH] D10674: Value profiling - patchset 3

[Xinliang David Li via llvm-commits]

>>> Is this needed? I don't see StringTable is written out anywhere.
>>
>> Both raw and indexed readers maintain their own StringTable, so the
>> indirect call target value entries arrive pointing always to the reader's
>> string table. This routine would translate all the relevant value entries
>> to point to the entries in the writer's StringTable.
>>

Since this is practically a non-issue, it is probably good enough to
emit a warning (even with debug build) when collision is detected when
HashKeyMap is formed during header reading.  Using multi-map (and
allow a false target to be injected) is another solution but looks
like an overkill.

David

>> Thanks,
>> -Betul
>>
>>> http://reviews.llvm.org/D10674
>>
>>
>>
>>
>>
>
>