[PATCH] D11862: Edits to CMake.rst for clarity's sake

Brian R. Gaeke via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 22 01:09:26 PDT 2015


gaeke marked 6 inline comments as done.
gaeke added a comment.

Thanks for your feedback. I will submit a new patch shortly.


================
Comment at: docs/CMake.rst:106
@@ +105,3 @@
+CMake requires that you specify for which build tool it shall generate
+files (e.g., GNU make, Visual Studio, or Xcode). If not specified on
+the command line, CMake tries to guess which build tool to use, based on
----------------
vsk wrote:
> Maybe just: "CMake requires that you specify a build tool (e.g ..."
I am going to go with "allows you to specify", as we go on immediately to state that CMake tries to figure out which tool you want to use if you don't specify it.

================
Comment at: docs/CMake.rst:113
@@ -110,2 +112,3 @@
+see a list of the available generators on your system, execute
 
 .. code-block:: console
----------------
vsk wrote:
> The text-wrapping changes here for some reason. Could you maintain the original width?
I have tried to do this in my new version. Sorry about that. There were a lot of changes in this paragraph.


http://reviews.llvm.org/D11862





More information about the llvm-commits mailing list