[PATCH] D12078: [llvm-readobj] ELF: Factor out common code

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 17:51:51 PDT 2015


vsk added a subscriber: vsk.

================
Comment at: ELFDumper.cpp:1153
@@ -1154,1 +1152,3 @@
+void ELFDumper<ELFT>::printSymbolsHelper(bool IsDynamic)
+{
   const Elf_Shdr *Symtab = DotSymtabSec;
----------------
Nitpick: clang-format puts the brace on the previous line.

================
Comment at: ELFDumper.cpp:1154
@@ -1154,2 +1153,3 @@
+{
   const Elf_Shdr *Symtab = DotSymtabSec;
   ErrorOr<StringRef> StrTableOrErr = Obj->getStringTableForSymtab(*Symtab);
----------------
Does this need to be DotDynSymSec when IsDynamic=true?


http://reviews.llvm.org/D12078





More information about the llvm-commits mailing list