[PATCH] D12055: AMDGPU: Add cache invalidation instructions.

[Tom Stellard via llvm-commits]

tstellarAMD added a comment.

In http://reviews.llvm.org/D12055#230382, @arsenm wrote:

> In http://reviews.llvm.org/D12055#230374, @tstellarAMD wrote:
>
> > Is there a reason to split the assembler tests into 3 files?
> >
> > I can look into the problem with VI.
>
>
> I think I was mostly just confused by always testing with not. I can probably merge them back in, although I think it would also make sense to split cases that are supposed to error into separate tests


I went back and forth on this a lot, but I think for testing just instructions that are legal on some targets, but not others, it's better to have all the tests in the same file.  Otherwise, we will end up having to duplicate the same assembly string across multiple files.


http://reviews.llvm.org/D12055