[PATCH] D12168: Improve the determinism of MergeFunctions

[JF Bastien via llvm-commits]

jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.

lgtm besides two nits.


================
Comment at: test/Transforms/MergeFunc/constant-entire-value.ll:2
@@ +1,3 @@
+; RUN: opt -S -mergefunc < %s | FileCheck %s
+
+define internal i32 @sum(i32 %x, i32 %y) {
----------------
Add a description of what this is doing (the `0` check isn't obvious).

================
Comment at: test/Transforms/MergeFunc/constant-entire-value.ll:22
@@ +21,3 @@
+define internal i32 @plus(i32 %x, i32 %y) {
+; CHECK-NOT: @plus
+  %sum = add i32 %x, %y
----------------
`CHECK-NOT` like this is usually done with a different `RUN: opt ...` line, which checks the entire file.


http://reviews.llvm.org/D12168