[PATCH] D12236: [compiler-rt] [asan] Enable DFSan for AArch64/42-bit VMA

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 13:55:46 PDT 2015


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM after updating the comment. Thanks!


================
Comment at: lib/dfsan/dfsan.cc:132
@@ +131,3 @@
+# elif SANITIZER_AARCH64_VMA == 42
+static const uptr kUnionTableAddr = 0x8000000000;
+# endif
----------------
zatrazz wrote:
> rengolin wrote:
> > This looks wrong with the table above?
> In fact is the contraty, the comment needs update. I'll change it.
makes sense, this is 3 bits to the left. :)


http://reviews.llvm.org/D12236





More information about the llvm-commits mailing list