[PATCH] D12084: [llvm-readobj] Add support for MachO DataInCodeDataCommand

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 13:31:13 PDT 2015


I went forward and commited this as r245732.
If anybody has other opinions about the lexicon -- we can change it later.
 I'll start converting macho-dump tests soon so this feature will get tested.

Thanks,

--
Davide

On Tue, Aug 18, 2015 at 2:05 PM, Davide Italiano via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> davide added a comment.
>
> Thank you for reviewing, Rafael. I agree with -macho-data-in-code. About the difference between region/entries -- I don't have strong preferences, so I'll change as you say (I just blatantly copied what was used in macho-dump). Maybe grosbach or enderby have a different opinion.
>
>
> http://reviews.llvm.org/D12084
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
Davide

"A mathematical theory is not to be considered complete until you have
made it so clear that you can explain it to the first man whom you
meet on the street." (D. Hilbert)


More information about the llvm-commits mailing list