[PATCH] D9751: Add HSAIL target

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/HSAIL/HSAILISelDAGToDAG.cpp:606-608
@@ +605,5 @@
+
+bool HSAILDAGToDAGISel::SelectAddrCommon(SDValue Addr, SDValue &Base,
+                                         SDValue &Reg, int64_t &Offset,
+                                         MVT ValueType, int Depth) const {
+  if (Depth > 5)
----------------
Does this function really need to be recursive?  it seems more complicated than it needs to be.

================
Comment at: lib/Target/HSAIL/MCTargetDesc/RawVectorOstream.h:23-25
@@ +22,5 @@
+
+namespace llvm {
+
+class RawVectorOstream : public raw_pwrite_stream {
+  static const size_t AllocationChunk = 1024;
----------------
Is there a reason this isn't in common code? 


http://reviews.llvm.org/D9751