[PATCH] D11978: [mips][microMIPS] Implement ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt, MADDF.fmt, MSUBF.fmt and NEG.fmt instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a couple indentation nits.


================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:299-301
@@ +298,5 @@
+/// Floating Point Instructions
+class FARITH_MMR6_DESC_BASE<string instr_asm, RegisterOperand RC,
+  InstrItinClass Itin, bit isComm, SDPatternOperator OpNode= null_frag>
+    : HARDFLOAT {
+  dag OutOperandList = (outs RC:$fd);
----------------
Two nits:
Indentation of line 300. Arguments should be fully hanging or next line should be aligned to first argument.

There should be a space before the '='

================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:330-332
@@ +329,5 @@
+
+class FMOV_FNEG_MMR6_DESC_BASE<string instr_asm, RegisterOperand DstRC,
+  RegisterOperand SrcRC, InstrItinClass Itin,
+  SDPatternOperator OpNode = null_frag>
+    : HARDFLOAT, NeverHasSideEffects {
----------------
Nit: Indentation


http://reviews.llvm.org/D11978