[PATCH] D12210: [InstCombine] Transform A & (L - 1) u< L --> L != 0

[Sanjoy Das via llvm-commits]

Yeah, the code is just wrong; I should have been more careful here.

Thanks for reverting, I'll fix this tomorrow.

Sent from a mobile device, please excuse typos.
On Aug 21, 2015 12:57 AM, "escha" <escha at apple.com> wrote:

> escha added a subscriber: escha.
>
> ================
> Comment at:
> llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp:3495
> @@ +3494,3 @@
> +    if (BO0) {
> +      // Transform  A & (L - 1) `ult` L --> L != 0
> +      Value *L;
> ----------------
> Is it just me, or does this never even look at the RHS of the comparison?
>
> It seems to be matching the following, despite the comment: A & (L - 1)
> `ult` M -> L != 0 for any M.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D12210
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150821/634ac6c6/attachment.html>