[PATCH] D11933: Extending debug ranges

[Vikram TV via llvm-commits]

On Fri, Aug 21, 2015 at 2:30 AM, Alex L <arphaman at gmail.com> wrote:

>
>
> 2015-08-20 9:42 GMT-07:00 Vikram TV <vikram.tarikere at gmail.com>:
>
>>
>> On Thu, Aug 20, 2015 at 5:58 AM, Alex Lorenz <arphaman at gmail.com> wrote:
>>
>>> arphaman added inline comments.
>>>
>>> ================
>>> Comment at: test/DebugInfo/MIR/extend-debug-range.mir:249
>>> @@ +248,3 @@
>>> +
>>> +    MOV32mr %rip, 1, _, @m, _, %ecx, debug-location !37 :: (store 4
>>> into %ir.m)
>>> +    dead undef %edi = MOV32ri64 @.str, implicit-def %rdi,
>>> debug-location !38
>>> ----------------
>>> I tweaked the syntax for the memory operands slightly while working on
>>> the fix for the problem you reported, so this instruction should be as
>>> follows now:
>>>
>>>      MOV32mr %rip, 1, _, @m, _, %ecx, debug-location !37 :: (store 4
>>> into @m)
>>>
>>>
>>> http://reviews.llvm.org/D11933
>>>
>>>
>>>
>>>
>> Hi,
>>
>> I updated to latest llvm and made the change you suggested. But with
>> -march=x86, I see an error like this:
>> error: extend-debug-range.mir:191:33: invalid DWARF register
>>     CFI_INSTRUCTION .cfi_offset %rbp, -16
>>
>
> The file was produced for the x86-64 architecture, so you have to use
> -march=x86-64 in order for run llc on it. The target directory should still
> be 'X86' though.
>
> Okay! I should have tried x86-64. Sorry about that.

>
>> Is it okay to consider the current patch without .mir test cases? I will
>> send a separate patch with .mir test cases once MIR serialization is stable.
>>
>
> I would be ok with that.
>

I will send an updated patch.

>
> Cheers,
> Alex
>
>
>>
>> --
>>
>> Good time...
>> Vikram TV
>> CompilerTree Technologies
>> Mysore, Karnataka, INDIA
>>
>
>


-- 

Good time...
Vikram TV
CompilerTree Technologies
Mysore, Karnataka, INDIA
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150821/ff587232/attachment.html>