[compiler-rt] r245596 - [asan] Enable ASan for AArch64/42-bit VMA

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 14:56:12 PDT 2015


> On Aug 20, 2015, at 2:15 PM, Adhemerval Zanella <adhemerval.zanella at linaro.org> wrote:
> 
> Sorry about that, I have pushed r245596 that sets SANITIZER_AARCH64_VMA
> if is not defined (regardless if SANITIZER_LINUX is defined or not). 
> 
> On 20-08-2015 17:37, Renato Golin wrote:
>> On 20 August 2015 at 21:00, Pete Cooper via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> This is breaking our internal Darwin based bots.  I believe the reason is that this code has no else case, so we never set the variable.  There’s code elsewhere that checks for linux.  I wonder if there needs to be ‘elif not linux’ on the end here to support Darwin and other architectures?
>> 
>> Oh, yes! Sorry about that.
No problem.  Thanks for the quick fix!

And yeah, its passed the builder now.

Thanks to you both.
Pete
>> 
>> Adhemerval, do you have a fix handy?
>> 
>> cheers,
>> --renato
>> 



More information about the llvm-commits mailing list