[PATCH] D11180: Fixed debug info generation for function static variables, typedef, and records

[David Blaikie via llvm-commits]

dblaikie added inline comments.

================
Comment at: test/DebugInfo/X86/PR24008.ll:16
@@ +15,3 @@
+;;
+;;class Foo{
+;;public:
----------------
What are the important features of this test? Why are they important? It might be helpful to comment them.

At the moment this looks like it could be simplified down to:

  void f1() {
    while (true) {
      struct nested {
        static void f2() {}
      };
      nested::f2();
    }
  }

Though even then, I'm not sure what the tricky part of this test is. You've tested nested types in other test cases - was there something in the code you had to write specifically to support this nested type compared to the other tests?

(is there something in your patch I could remove that would cause this test to fail, but not the other tests?)


Repository:
  rL LLVM

http://reviews.llvm.org/D11180