[PATCH] D12058: [NVPTX] truncating 64-bit to 32-bit is free

[Eli Bendersky via llvm-commits]

eliben added inline comments.

================
Comment at: lib/Target/NVPTX/NVPTXISelLowering.h:464
@@ +463,3 @@
+    // Truncating 64-bit to 32-bit is free in SASS.
+    if (!SrcTy->isIntegerTy() || !DstTy->isIntegerTy())
+      return false;
----------------
I'd just && the four conditions in the 'return' statement here, would make it clearer IMHO. But it's just style so up to you

================
Comment at: test/Transforms/LoopStrengthReduce/NVPTX/trunc.ll:1
@@ +1,2 @@
+; RUN: opt < %s -loop-reduce -S | FileCheck %s
+
----------------
Can you add a detailed comment explaining what this is testing?


http://reviews.llvm.org/D12058