[PATCH] D12136: [X86] Emit more efficient >= comparisons against 0
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 19 13:37:57 PDT 2015
spatel added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:24112
@@ +24111,3 @@
+
+ // Create a greater-than comparison against -1.
+ SDLoc DL(N);
----------------
It would be great to add the earlier review comment about the difference between SETGT -1 and SETGE 0 here in the code comment. Save someone a little wondering down the line. :)
I have no further comments.
Thanks, David!
http://reviews.llvm.org/D12136
More information about the llvm-commits
mailing list