[PATCH] D12160: [asan] Enable ASan for AArch64/42-bit VMA

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 13:27:53 PDT 2015


eugenis added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform.h:111
@@ -104,1 +110,3 @@
+# define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 42)
+#elif defined(__mips__) || (defined(__aarch64) && SANITIZER_AARCH64_VMA == 39)
 # define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 40)
----------------
zatrazz wrote:
> eugenis wrote:
> > Does this say that mmap range for 39-bit VMA is 40 bit? That's probably not correct.
> It is not, although I have not seen any mmap failures in testcase for 39-bit VMA. I will change it anyway.
I believe this will not cause any test failures. It will waste some memory though, by inflating the large allocator's bitmap.



http://reviews.llvm.org/D12160





More information about the llvm-commits mailing list