[PATCH] D12161: [compiler-rt] Add aarch64 syscall optimization support

[Adhemerval Zanella via llvm-commits]

zatrazz added a comment.

Thanks for the review, I will repost the patch with the recommend changes.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:102
@@ -101,1 +101,3 @@
+#elif SANITIZER_LINUX && defined(__aarch64__)
+#include "sanitizer_syscall_linux_aarch64.inc"
 #else
----------------
samsonov wrote:
> Please add this file to `lib/sanitizer_common/CMakeLists.txt`
I will add it.

================
Comment at: lib/sanitizer_common/sanitizer_syscall_linux_aarch64.inc:28
@@ +27,3 @@
+
+static uptr __internal_syscall(u64 nr, long arg1) {
+  register long x8 asm("x8") = nr;
----------------
samsonov wrote:
> Any specific reason for not using u64 for argument types as we do on x86_64?
Not really, I will change it to u64.


http://reviews.llvm.org/D12161