[PATCH] D12160: [asan] Enable ASan for AArch64/42-bit VMA

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform.h:85
@@ +84,3 @@
+// VMA size definition for architecture that support multiple sizes.
+// AArch64 has 3 VMA sizes: 39, 42 and 48.
+#if SANITIZER_LINUX && defined(__aarch64__)
----------------
zatrazz wrote:
> rengolin wrote:
> > You haven't added any logic for 48 bits. Would it be simple to do it?
> Yes, for ASAN it will be since the only requirement is the 'kAArch64_ShadowOffset64' (which I think it should be 1<< 45). I have not added it because I have no system to actually test it.
Thought as much. But it's odd to mention and not do anything.

Maybe add a "(unsupported)" right after the number 48 in the comment would clear the confusion.


http://reviews.llvm.org/D12160