[PATCH] D11648: InstCombinePHI: Partial simplification of identity operations

Jakub Kuderski via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 05:25:42 PDT 2015


kuhar added a comment.

In http://reviews.llvm.org/D11648#227701, @majnemer wrote:

> In http://reviews.llvm.org/D11648#227672, @kuhar wrote:
>
> > I've changed the check form using isSafeToSpeculativelyExecute to simply checking for division instruction - from all the cases I deal with only this one could result in trap.
>
>
> Why is it OK to hoist if the incoming block unconditionally branches or ends in a switch or indirectbr?


It may be not, good catch. Thanks.


Repository:
  rL LLVM

http://reviews.llvm.org/D11648





More information about the llvm-commits mailing list