[LNT] r245425 - [lnt] Correct delta and percent-change of geometric mean.

[Daniel Sanders via llvm-commits]

Author: dsanders
Date: Wed Aug 19 03:51:46 2015
New Revision: 245425

URL: http://llvm.org/viewvc/llvm-project?rev=245425&view=rev
Log:
[lnt] Correct delta and percent-change of geometric mean.

The geometric mean of a dataset is not the samples it is calculated from.
It is a single calculated sample. Without this patch, the delta and percent
change fields will pick the individual test with the smallest value change
and calculate their value from that, producing very misleading results.
It should show the delta/percent-change of the geometric mean itself.


Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=245425&r1=245424&r2=245425&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Wed Aug 19 03:51:46 2015
@@ -300,11 +300,13 @@ class RunInfo(object):
             prev_values,run_values = zip(*[(cr.previous,cr.current) for _,_,cr in tests])
             prev_values = [x for x in prev_values if x is not None]
             run_values = [x for x in run_values if x is not None]
+            prev_values = [calc_geomean(prev_values)]
+            run_values = [calc_geomean(run_values)]
         else:
             prev_values,run_values = [], []
 
         
-        return ComparisonResult(calc_geomean,
+        return ComparisonResult(self.aggregation_fn,
                                 cur_failed=bool(run_values),
                                 prev_failed=bool(prev_values),
                                 samples=run_values,