[polly] r245423 - Do not use negative option name

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 01:22:06 PDT 2015


Author: grosser
Date: Wed Aug 19 03:22:06 2015
New Revision: 245423

URL: http://llvm.org/viewvc/llvm-project?rev=245423&view=rev
Log:
Do not use negative option name

Instead of -polly-no-tiling, we use -polly-tiling=false to disable tiling.

Modified:
    polly/trunk/lib/Transform/ScheduleOptimizer.cpp
    polly/trunk/test/ScheduleOptimizer/line-tiling-2.ll
    polly/trunk/test/ScheduleOptimizer/prevectorization-without-tiling.ll
    polly/trunk/test/ScheduleOptimizer/rectangular-tiling.ll
    polly/trunk/www/example_load_Polly_into_clang.html

Modified: polly/trunk/lib/Transform/ScheduleOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Transform/ScheduleOptimizer.cpp?rev=245423&r1=245422&r2=245423&view=diff
==============================================================================
--- polly/trunk/lib/Transform/ScheduleOptimizer.cpp (original)
+++ polly/trunk/lib/Transform/ScheduleOptimizer.cpp Wed Aug 19 03:22:06 2015
@@ -71,14 +71,10 @@ using namespace polly;
 
 #define DEBUG_TYPE "polly-opt-isl"
 
-namespace polly {
-bool DisablePollyTiling;
-}
-static cl::opt<bool, true>
-    DisableTiling("polly-no-tiling",
-                  cl::desc("Disable tiling in the scheduler"),
-                  cl::location(polly::DisablePollyTiling), cl::init(false),
-                  cl::ZeroOrMore, cl::cat(PollyCategory));
+static cl::opt<bool> EnableTiling("polly-tiling",
+                                  cl::desc("Enable loop tiling"),
+                                  cl::init(true), cl::ZeroOrMore,
+                                  cl::cat(PollyCategory));
 
 static cl::opt<std::string>
     OptimizeDeps("polly-opt-optimize-only",
@@ -283,7 +279,7 @@ isl_schedule_node *IslScheduleOptimizer:
     return Node;
   }
 
-  if (!DisableTiling) {
+  if (EnableTiling) {
     auto Ctx = isl_schedule_node_get_ctx(Node);
     auto Sizes = isl_multi_val_zero(isl_space_copy(Space));
     for (unsigned i = 0; i < Dims; i++) {

Modified: polly/trunk/test/ScheduleOptimizer/line-tiling-2.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScheduleOptimizer/line-tiling-2.ll?rev=245423&r1=245422&r2=245423&view=diff
==============================================================================
--- polly/trunk/test/ScheduleOptimizer/line-tiling-2.ll (original)
+++ polly/trunk/test/ScheduleOptimizer/line-tiling-2.ll Wed Aug 19 03:22:06 2015
@@ -1,4 +1,5 @@
-; RUN: opt %loadPolly -polly-detect-unprofitable -polly-opt-isl -analyze -polly-no-tiling=0 -polly-ast -polly-tile-sizes=1,64 < %s | FileCheck %s
+; RUN: opt %loadPolly -polly-detect-unprofitable -polly-opt-isl -analyze \
+; RUN:                -polly-ast -polly-tile-sizes=1,64 < %s | FileCheck %s
 
 ; CHECK: for (int c0 = 0; c0 <= 1023; c0 += 1)
 ; CHECK:   for (int c1 = 0; c1 <= 7; c1 += 1)

Modified: polly/trunk/test/ScheduleOptimizer/prevectorization-without-tiling.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScheduleOptimizer/prevectorization-without-tiling.ll?rev=245423&r1=245422&r2=245423&view=diff
==============================================================================
--- polly/trunk/test/ScheduleOptimizer/prevectorization-without-tiling.ll (original)
+++ polly/trunk/test/ScheduleOptimizer/prevectorization-without-tiling.ll Wed Aug 19 03:22:06 2015
@@ -1,4 +1,4 @@
-; RUN: opt -S %loadPolly -polly-detect-unprofitable -basicaa -polly-opt-isl -polly-no-tiling -polly-vectorizer=polly -polly-ast -analyze < %s | FileCheck %s
+; RUN: opt -S %loadPolly -polly-detect-unprofitable -basicaa -polly-opt-isl -polly-tiling=false -polly-vectorizer=polly -polly-ast -analyze < %s | FileCheck %s
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 
 @C = common global [1536 x [1536 x float]] zeroinitializer, align 16

Modified: polly/trunk/test/ScheduleOptimizer/rectangular-tiling.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScheduleOptimizer/rectangular-tiling.ll?rev=245423&r1=245422&r2=245423&view=diff
==============================================================================
--- polly/trunk/test/ScheduleOptimizer/rectangular-tiling.ll (original)
+++ polly/trunk/test/ScheduleOptimizer/rectangular-tiling.ll Wed Aug 19 03:22:06 2015
@@ -1,5 +1,5 @@
 ; RUN: opt %loadPolly -polly-detect-unprofitable -polly-opt-isl -analyze -polly-ast -polly-tile-sizes=256,16 < %s | FileCheck %s
-; RUN: opt %loadPolly -polly-detect-unprofitable -polly-opt-isl -analyze -polly-no-tiling -polly-ast -polly-tile-sizes=256,16 -polly-no-early-exit < %s | FileCheck %s --check-prefix=NOTILING
+; RUN: opt %loadPolly -polly-detect-unprofitable -polly-opt-isl -analyze -polly-tiling=false -polly-ast -polly-tile-sizes=256,16 -polly-no-early-exit < %s | FileCheck %s --check-prefix=NOTILING
 
 ; CHECK: for (int c0 = 0; c0 <= 3; c0 += 1)
 ; CHECK:   for (int c1 = 0; c1 <= 31; c1 += 1)

Modified: polly/trunk/www/example_load_Polly_into_clang.html
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/www/example_load_Polly_into_clang.html?rev=245423&r1=245422&r2=245423&view=diff
==============================================================================
--- polly/trunk/www/example_load_Polly_into_clang.html (original)
+++ polly/trunk/www/example_load_Polly_into_clang.html Wed Aug 19 03:22:06 2015
@@ -120,7 +120,7 @@ To disable the optimizer entirely use th
 
 <h3>Disable tiling in the optimizer</h3>
 By default both optimizers perform tiling, if possible. In case this is not
-wanted the option <b>-polly-no-tiling</b> can be used to disable it. (This
+wanted the option <b>-polly-tiling=false</b> can be used to disable it. (This
 option disables tiling for both optimizers).
 
 <h3>Ignore possible aliasing</h3>




More information about the llvm-commits mailing list