[PATCH] D12139: Add 'strlen' formation to LoopIdiomRecognize

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 00:06:37 PDT 2015


Prazek added a subscriber: Prazek.
Prazek added a comment.

I don't think I have enough power to say LGTM, but looks legit to me.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1105
@@ +1104,3 @@
+  for (PHINode *IndVar = dyn_cast<PHINode>(LoopBody->begin());
+       IndVar;
+       IndVar = dyn_cast<PHINode>(IndVar->getNextNode())) {
----------------
I think it would look better if You would put this in the same line. Now it somehow look like 
for (... );
  IndVar;
  IndVar = ...




Repository:
  rL LLVM

http://reviews.llvm.org/D12139





More information about the llvm-commits mailing list