[PATCH] D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}.

[Josh Gao via llvm-commits]

jmgao marked 2 inline comments as done.

================
Comment at: lib/builtins/arm/aeabi_cdcmpeq_helper.c:19
@@ +18,3 @@
+int __aeabi_cdcmpeq_helper(int32_t a, int32_t b) {
+    return isnan_d(a) || isnan_d(b);
+}
----------------
srhines wrote:
> jmgao wrote:
> > rengolin wrote:
> > > srhines wrote:
> > > > Couldn't this be using __builtin_isnan instead of redefining it?
> > > or even calling it directly from the asm function?
> > Doesn't __builtin_isnan do overloading via magic and/or generic macros? Is there an actual symbol I can jump to?
> It looks like you resolved the issue here (by calling through with the appropriate C type). Was this just a stale reply?
It was a response to the "calling it directly from the asm function" post from @rengolin in case that there actually is a way to call __builtin_isnan directly from asm, so I could do that instead.


http://reviews.llvm.org/D12089