[PATCH] D11847: [BasicAA] Fix zext & sext handling

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 15:43:58 PDT 2015


hfinkel added a comment.

In http://reviews.llvm.org/D11847#227079, @hans wrote:

> In http://reviews.llvm.org/D11847#227064, @hfinkel wrote:
>
> > In http://reviews.llvm.org/D11847#227037, @hans wrote:
> >
> > > Did this get committed? Is this a fix we need for 3.7?
> >
> >
> > From what qcolombet mentioned, this fixes a bug introduced in r221876. That would make it nice to have in 3.7, and I'm fine with it being committed to trunk and making my requested commentary improvements in follow-up. However, this is not purely a bug fix, and furthermore, this fix itself has been committed/reverted before as well. I'm nervous about merging it into the release branch late in the release cycle. It might be best to revert r221876 in the release branch instead. Is there going to be another release candidate at this point before 3.7?
>
>
> r221876 also doesn't look like a trivial patch. It's hard to follow along with all the reverted reverts here.
>
> From what I understand, PR23626 that's mentioned here was already fixed by reverting something else on 3.7, so maybe we don't need this or reverting r221876?
>
> There have been a number of merges after 3.7-rc2, so there will be an rc3, but I'm hoping that will become the final one.


Okay; I'll make sure this gets committed today.


http://reviews.llvm.org/D11847





More information about the llvm-commits mailing list