[PATCH] D12112: x32. Fixes jmp %reg in x32

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: test/CodeGen/X86/x32-indirectbr.ll:21
@@ +20,3 @@
+}
+; CHECK: movl {{.*}}, %{{e|r}}[[REG:.[^d]*]]{{d?}}
+; CHECK: jmpq *%r[[REG]]
----------------
jpp wrote:
> dschuff wrote:
> > %{{e|r}}
> > if you are checking for a movl, then %rXX shouldn't be allowed, should it?
> They are, if you are using the new registers( r8d-15d). The regexp could potentially be improved. 
Oh ok, I misunderstood. and the regex is explicitly trying to throw away the d for REG. It makes sense, but probably worth a comment saying that the test is checking for a 32-bit mov followed by a jump through the 64-bit version of the same register.


http://reviews.llvm.org/D12112