[PATCH] D12107: Replace overflow check in loop vectorization with minimum loop iterations check

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 13:46:55 PDT 2015


wmi updated this revision to Diff 32445.
wmi added a comment.

Thanks for the quick response.

> Please add tests that this also works with interleave factor that is not 1.


Done

> Don't use MaxVectorSize but rather the selected unroll factor times the selected vectorization factor (InnerLoopVectorizer::UF * InnerLoopVectorizer::VF) this is the step the loop will iterate by.


Ah, that is right. Fixed.

> Please don't remove the explanation for the need of checking overflow.


Done.


Repository:
  rL LLVM

http://reviews.llvm.org/D12107

Files:
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Transforms/LoopVectorize/induction.ll
  test/Transforms/LoopVectorize/miniters.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12107.32445.patch
Type: text/x-patch
Size: 7077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150818/08f75531/attachment.bin>


More information about the llvm-commits mailing list