[PATCH] D12098: [WinEH] Calculate state numbers for the new EH representation

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: include/llvm/CodeGen/WinEHFuncInfo.h:125
@@ -124,3 +124,3 @@
   int CatchObjRecoverIdx;
-  Function *Handler;
+  Value *Handler;
 };
----------------
This guy should be const. I'm reasonably confident that the const cascading will stop there, since all we use it for is to get an MCSymbol.

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:2611
@@ +2610,3 @@
+    }
+    HT.Handler = const_cast<BasicBlock *>(CPI->getParent());
+    // FIXME: Pass CPI->getArgOperand(1).
----------------
We should kill this const_cast too.


http://reviews.llvm.org/D12098