[PATCH] D12099: Fix FREM on 32-bit MSVC on x86

Mitch Bodart via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 08:24:52 PDT 2015


mbodart added inline comments.

================
Comment at: test/CodeGen/X86/frem-msvc32.ll:7
@@ +6,3 @@
+; CHECK: @do_frem32
+; CHECK: calll _fmod
+define float @do_frem32(float %a, float %b) {
----------------
As written, this test will pass without your compiler changes as _fmod is a substring of _fmodf.

It needs to either incorporate CHECK-NOT fmodf, or use a regular expression that matches _fmod but not _fmodf.  Perhaps this:

; CHECK: calll {{_fmod$}}


http://reviews.llvm.org/D12099





More information about the llvm-commits mailing list