[llvm] r244448 - Prevent the scalarizer from caching incorrect entries

[Hans Wennborg via llvm-commits]

On Mon, Aug 17, 2015 at 2:21 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
>> From: "Hans Wennborg via llvm-commits" <llvm-commits at lists.llvm.org>
>> To: "Fraser Cormack" <fraser at codeplay.com>
>> Cc: "llvm-commits" <llvm-commits at lists.llvm.org>
>> Sent: Monday, August 17, 2015 3:29:32 PM
>> Subject: Re: [llvm] r244448 - Prevent the scalarizer from caching incorrect entries
>>
>> On Fri, Aug 14, 2015 at 11:28 AM, Hans Wennborg <hans at chromium.org>
>> wrote:
>> > On Tue, Aug 11, 2015 at 9:42 AM, Hans Wennborg <hans at chromium.org>
>> > wrote:
>> >> On Mon, Aug 10, 2015 at 7:48 AM, Fraser Cormack via llvm-commits
>> >> <llvm-commits at lists.llvm.org> wrote:
>> >>> Author: fcormack
>> >>> Date: Mon Aug 10 09:48:47 2015
>> >>> New Revision: 244448
>> >>>
>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=244448&view=rev
>> >>> Log:
>> >>> Prevent the scalarizer from caching incorrect entries
>> >>>
>> >>> The scalarizer can cache incorrect entries when walking up a
>> >>> chain of
>> >>> insertelement instructions. This occurs when it encounters more
>> >>> than one
>> >>> instruction that it is not actively searching for, as it
>> >>> unconditionally caches
>> >>> every element it finds. The fix is to only cache the first
>> >>> element that it
>> >>> isn't searching for so we don't overwrite correct entries.
>> >>>
>> >>> Reviewers: hfinkel
>> >>>
>> >>> Differential Revision: http://reviews.llvm.org/D11559
>> >>
>> >> Should this be merged to 3.7?
>> >
>> > Ping?
>>
>> Ping?
>
> Who are you pinging? FWIW, it seems like a safe fix to me.

I was pinging Fraser (I figured this was clear with To: Fraser and Cc:
llvm-commits, but I guess being more explicit wouldn't hurt).

Chris: I think this invokes your catch-all ownership. OK to merge?

Thanks,
Hans