[PATCH] D11876: [Support] Always wait for GraphViz before opening the viewer

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

In http://reviews.llvm.org/D11876#226031, @aaron.ballman wrote:

> Will this cause incorrect behavior on non-Windows platforms where wait was false, but now causes the wait to happen. Specifically, I'm wondering about callers of ViewGraph().


I'd say the old behavior is incorrect on all platforms. If GraphViz takes longer to execute than it takes for the viewer to launch, it won't work on any system. I don't know why this is much more likely to happen on Windows.

I am working on Linux as well and it works nicely there. I don't know about MacOS as I don't have an Apple.


Repository:
  rL LLVM

http://reviews.llvm.org/D11876