[PATCH] D12066: Introduce the ScopExpander as a SCEVExpander replacement

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

AFAIU you always insert the new instructions into the entering block. What if the argument of SDiv/SRem depends of an inner loop induction variable (An point raised by Tobias in a mailing list discussion)?


================
Comment at: lib/Support/ScopHelper.cpp:261
@@ +260,3 @@
+
+  explicit ScopExpander(Scop &S, ScalarEvolution &SE, const DataLayout &DL,
+                        const char *Name)
----------------
ScopExpander doesn't need the Scop, only the Region.

================
Comment at: lib/Support/ScopHelper.cpp:294
@@ +293,3 @@
+    if (!StartIP)
+      setStartIP();
+
----------------
Introduce getStartIP() which sets StartIP if nullptr ?


http://reviews.llvm.org/D12066