[PATCH] llvm-build: Adopt generation of LLVM_LIBS_TO_EXPORT

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:48:56 PDT 2015


Hi Brad,


>> Rather than special casing for gtest_* in LLVMBuild's code wouldn't it
>> make more sense to use the existing ``installed = 0`` attribute in
>> ``utils/unittest/LLVMBuild.txt`` to tell the relevant method to not
>> emit that component into ``LLVM_LIBS_TO_EXPORT``?
>
> Yes, that makes sense.  However, I'm not familiar enough with the
> infrastructure to do it that way.  I'd be happy to review such an
> alternative patch though.

Sorry it's taken me so long to get round to this. Attached is an
alternative version of patch 0003 which filters based on the
"installed" property.
It also emits the libraries that were skipped as comments into
``Makefile.llvmbuild``.

Thanks,
Dan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003v2-Filter-libraries-that-are-not-installed-out-of-CMake.patch
Type: text/x-patch
Size: 2847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150817/d69f59eb/attachment.bin>


More information about the llvm-commits mailing list