[PATCH] D11877: [Support] On Windows, generate PDF files for graphs and open with associated viewer

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:13:48 PDT 2015


aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman requested changes to this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision now requires changes to proceed.

I think it's close to being ready; one minor nit still (sorry for not bringing it up sooner).


================
Comment at: lib/Support/GraphWriter.cpp:241
@@ +240,3 @@
+    std::string StartArg;
+    if (Viewer == VK_CmdStart)
+      StartArg =
----------------
I think this code block should be moved into the case VK_CmdStart block below.


http://reviews.llvm.org/D11877





More information about the llvm-commits mailing list