[PATCH] D11933: Extending debug ranges

[Eric Christopher via llvm-commits]

On Mon, Aug 17, 2015 at 8:55 AM Adrian Prantl via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> > On Aug 17, 2015, at 7:05 AM, Vikram TV <vikram.tarikere at gmail.com>
> wrote:
> >
> > tvvikram added inline comments.
> >
> > ================
> > Comment at: lib/CodeGen/DebugValueFixup.cpp:2
> > @@ +1,3 @@
> > +//===-- DebugValueFixup.cpp - Fixup Debug Value MIs
> -----------------------===//
> > +//
> > +//                     The LLVM Compiler Infrastructure
> > ----------------
> > Is it okay to name the pass as "ExtendDebugValueRangeAndLocation" ?
> >
> > ================
> > Comment at: test/DebugInfo/extend-debug-range.ll:1
> > @@ +1,2 @@
> > +; RUN: llc -print-machineinstrs=dbgval-fixup %s 2>&1 | FileCheck %s
> > +
> > ----------------
> > I am checking the generated machine instructions after the new pass to
> check for propagated debug ranges. But llc will also generate the .s file.
> Now, I tried using -stop-after option to llc, but it still generates the .s
> file.
> >
>
> +Alex, can you help Vikram in getting started with MIR serialization? I
> think this pass would be a perfect use case for it.
>
>
I think we should test both for now, the MIR serialization isn't there yet
and I'd prefer something that can be tested via looking at DWARF as well.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150817/420b16e4/attachment.html>