[PATCH] D12072: [FIX] Restrict the AST build with the assumed context

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 02:07:03 PDT 2015


grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

This new fix looks good to me.

Please update the commit message to explain the issue and the resolution. I would appreciate if you give some more details about the context, such that other people looking at your commit learn about the necessary context of our scalar code generation.

Regarding the other fix, I did not yet look into this, but would probably leave it for now
as it is. If you want to get it in, we need to check if restricting the ast_build does not
have a high cost in case of a complicated assumed context.


http://reviews.llvm.org/D12072





More information about the llvm-commits mailing list