[PATCH] D12063: [PM] Port ScalarEvolution to the new pass manager.

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM.  I do have one question inline.

> It seems incredibly unlikely that today GVN or

>  another pass that invalidates SCEV can update values in *just* such

>  a way that a subsequent run of SCEV will incorrectly find lookups in

>  a cache, but it is theoretically possible and would be a nightmare to

>  debug.


I'd have been more worried about `InstCombiner::SimplifyDemandedBits` here.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8330
@@ +8329,3 @@
+  // memory.
+  Arg.BackedgeTakenCounts.clear();
+}
----------------
Won't this happen as part of `BackedgeTakenCounts(std::move(Arg.BackedgeTakenCounts))`?


http://reviews.llvm.org/D12063