[PATCH] D12066: Introduce the ScopExpander as a SCEVExpander replacement

[Johannes Doerfert via llvm-commits]

jdoerfert added a comment.

Some comments.


================
Comment at: lib/CodeGen/BlockGenerators.cpp:387
@@ -386,3 +386,3 @@
 
-    if (R.contains(UI))
+    if (R.contains(UI) || EnteringBB == UI->getParent())
       continue;
----------------
This is needed as we otherwise think the new instructions are escape users, however I think we have to create enforce a new and initially empty entering block now.

================
Comment at: lib/Support/ScopHelper.cpp:286
@@ +285,3 @@
+
+    if (StartIP)
+      setStartIP();
----------------
Not is missing.

================
Comment at: lib/Support/ScopHelper.cpp:349
@@ +348,3 @@
+                            Instruction *IP) {
+  errs() << "Expand: " << *E << "\n";
+  ScopExpander Expander(S, SE, DL, Name);
----------------
left over


http://reviews.llvm.org/D12066