[PATCH] D12060: AMDGPU: Fix not adding exec to defs of cmpx instruction pseudos

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 15 22:46:02 PDT 2015


arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.

This was only set on the final _si/_vi version, but not on the pseudos most of codegen sees.

No test since these instructions aren't used yet.


http://reviews.llvm.org/D12060

Files:
  lib/Target/AMDGPU/SIInstrInfo.td

Index: lib/Target/AMDGPU/SIInstrInfo.td
===================================================================
--- lib/Target/AMDGPU/SIInstrInfo.td
+++ lib/Target/AMDGPU/SIInstrInfo.td
@@ -1446,6 +1446,7 @@
 
   def "" : VOP3_Pseudo <outs, ins, pattern, opName>,
            VOP2_REV<revOp#"_e64", !eq(revOp, opName)> {
+    let Defs = !if(defExec, [EXEC], []);
     let SchedRW = sched;
   }
 
@@ -1648,6 +1649,7 @@
                    string revOpName = "", string asm = opName#"_e32 "#op_asm,
                    string alias_asm = opName#" "#op_asm> {
   def "" : VOPC_Pseudo <ins, pattern, opName> {
+    let Defs = !if(DefExec, [VCC, EXEC], [VCC]);
     let SchedRW = sched;
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12060.32233.patch
Type: text/x-patch
Size: 685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150816/b7a88547/attachment.bin>


More information about the llvm-commits mailing list