[PATCH] D12046: AMDGPU: Use DFS to avoid second loop over function

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 20:45:13 PDT 2015


arsenm added a comment.

In http://reviews.llvm.org/D12046#225002, @dberlin wrote:

> Do you actually use Visited outside of the iterator (It's not visible
>  in this patch if you do)?
>  If not, you should just use depth_first, not depth_first_ext.


No. I thought might have a use for it, but this doesn't use it yet. The comment on it also says "This iterator stores the 'visited' set in an external set, which allows it to be more efficient, and allows external clients to use the set for other purposes." so I figured if it's faster to just leave it


http://reviews.llvm.org/D12046





More information about the llvm-commits mailing list