[PATCH] D11907: LLVM support for -fthinlto option.

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

It seems a bit intrusive to make the BitcodeWriter aware of LTO. It seems you want it to handle your specific information at the end of a module block right?
Can we have a generic hook mechanism? For instance, we might provide a std::function callback instead of this ad-hoc boolean.


================
Comment at: include/llvm/Bitcode/BitcodeWriterPass.h:34
@@ -34,1 +33,3 @@
+                                    bool ShouldPreserveUseListOrder = false,
+                                    bool EmitThinLTOIndex = false);
 
----------------
Update doxygen?

================
Comment at: include/llvm/Bitcode/ReaderWriter.h:71
@@ -71,1 +70,3 @@
+                          bool ShouldPreserveUseListOrder = false,
+                          bool EmitThinLTOIndex = false);
 
----------------
ditto.


http://reviews.llvm.org/D11907