[PATCH] D10662: [x86] fix allowsMisalignedMemoryAccess() implementation

James Y Knight via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 08:25:12 PDT 2015


jyknight added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:1910
@@ +1909,3 @@
+    else
+      *Fast = Subtarget->isUnalignedMemAccessFast();
+  }
----------------
This (pre-existing code!) seems really wrong. "isUnalignedMemAccessFast" is a very-poorly-named predicate, which only really is intended to indicate whether unaligned SSE 16-byte memory accesses are fast.

I believe unaligned access of all other sizes should always be treated as fast on x86. Does it break anything if you fix that too while you're in here?



http://reviews.llvm.org/D10662





More information about the llvm-commits mailing list