[lld] r244934 - Template OutputSection only over Is64Bit.

[Sean Silva via llvm-commits]

On Thu, Aug 13, 2015 at 8:14 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 13 August 2015 at 23:05, Sean Silva <chisophugis at gmail.com> wrote:
> >
> >
> > On Thu, Aug 13, 2015 at 6:11 PM, Rafael Espíndola
> > <rafael.espindola at gmail.com> wrote:
> >>
> >> > Feel free to add this sort of thing to a TODO list of interesting
> things
> >> > to
> >> > look at in the future, but please avoid doing
> >> > microoptimization-without-a-measured-performance-benefit until we
> have a
> >> > working linker (and then, hopefully dropping the
> >> > "without-a-measured-performance-benefit"). Almost every single one of
> >> > these
> >> > "NFC" patches are stepping on Michael's toes and holding up real "FC"
> >> > patches that are what we need to get a working linker.
> >>
> >>
> >> That is the kind of behavior that landed us on the old lld.
> >
> >
> > Reality check: the old LLD was not slow due to lack of
> microoptimizations.
>
> Reality check: I told Michael it would not work when he first told me
> it was splitting sections and creating constraints to keep the parts
> together.
>

How is that relevant? I don't recall Michael ever particularly championing
for that design anyway. Anyway, at this point basing elf2 on Rui's design
has already dealt with all the macro-scale performance issues. The
"performance from the start" has already mostly been done by virtue of
that. All we really need is to add the corresponding ELF functionality. We
shouldn't need to worry too much about performance until we can actually
profile.

-- Sean Silva


>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150813/a78fa42c/attachment.html>