[llvm] r245007 - [PM/AA] Delete two pointlessly overridden methods on the AA interface by

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 19:16:12 PDT 2015


Author: chandlerc
Date: Thu Aug 13 21:16:12 2015
New Revision: 245007

URL: http://llvm.org/viewvc/llvm-project?rev=245007&view=rev
Log:
[PM/AA] Delete two pointlessly overridden methods on the AA interface by
the AA counter pass.

For pointsToConstantMemory, I think this is a "bug fix" as I think the
code as written will actually infloop if ever reached. For the
getModRefInfo, this is a no-op change but with a significantly simpler
form.

Modified:
    llvm/trunk/include/llvm/Analysis/AliasAnalysisCounter.h

Modified: llvm/trunk/include/llvm/Analysis/AliasAnalysisCounter.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/AliasAnalysisCounter.h?rev=245007&r1=245006&r2=245007&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/AliasAnalysisCounter.h (original)
+++ llvm/trunk/include/llvm/Analysis/AliasAnalysisCounter.h Thu Aug 13 21:16:12 2015
@@ -43,12 +43,6 @@ public:
   /// specified pass info.
   void *getAdjustedAnalysisPointer(AnalysisID PI) override;
 
-  // FIXME: We could count these too...
-  bool pointsToConstantMemory(const MemoryLocation &Loc,
-                              bool OrLocal) override {
-    return getAnalysis<AliasAnalysis>().pointsToConstantMemory(Loc, OrLocal);
-  }
-
   // Forwarding functions: just delegate to a real AA implementation, counting
   // the number of responses...
   AliasResult alias(const MemoryLocation &LocA,
@@ -56,10 +50,6 @@ public:
 
   ModRefInfo getModRefInfo(ImmutableCallSite CS,
                            const MemoryLocation &Loc) override;
-  ModRefInfo getModRefInfo(ImmutableCallSite CS1,
-                           ImmutableCallSite CS2) override {
-    return AliasAnalysis::getModRefInfo(CS1, CS2);
-  }
 };
 
 //===--------------------------------------------------------------------===//




More information about the llvm-commits mailing list